yuqian90 commented on a change in pull request #8867:
URL: https://github.com/apache/airflow/pull/8867#discussion_r427748879
##########
File path: airflow/sensors/base_sensor_operator.py
##########
@@ -70,6 +72,7 @@ def __init__(self,
timeout: float = 60 * 60 * 24 * 7,
soft_fail: bool = False,
mode: str = 'poke',
+ downstream_skip=None,
Review comment:
Thinking about this, I find it unnecessary to provide the
`downstream_skip` option. We should just remove the call to
`_do_skip_downstream_tasks()` altogether. That can be the only behaviour of
`soft_fail`.
My reason is that whoever not finding `_do_skip_downstream_tasks()`
counter-intuitive is most likely using only `all_success` trigger rule in their
DAGs. If we remove `_do_skip_downstream_tasks()`, those DAGs will not be
affected. Things will continue to work the same. That said, you should still
highlight this in the CHANGELOG so people are aware.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
