jhtimmins commented on a change in pull request #8836:
URL: https://github.com/apache/airflow/pull/8836#discussion_r427544257
##########
File path: requirements/requirements-python3.8.txt
##########
@@ -0,0 +1,370 @@
+# Editable install with no version control (apache-airflow==2.0.0.dev0)
Review comment:
@potiuk I seem to have done something incorrectly, because I'm seeing an
error when `check-apache-license` runs. Could you take a look at the steps I've
taken and let me know if anything seems incorrect?
Error: `Caused by: java.io.FileNotFoundException: /opt/airflow/bin/python` -
I presume the inclusion of `/opt/airflow` means that it's trying to use the CI
mount point, not the local ones?
Here's what I've done (locally).
1. Set `ARG DEPENDENCIES_EPOCH_NUMBER="4"` in Dockerfile.ci (previously was
3)
2. Set `PIP DEPENDENCIES_EPOCH_NUMBER="4"` in Dockerfile.ci (previously was
3)
3. Set `AIRFLOW_CONTAINER_CI_OPTIMISED_BUILD="false"`
4. Ran `./breeze generate-requirements --python 3.8` locally
5. Ran `./breeze generate-requirements --python 3.7` locally
6. Ran `./breeze generate-requirements --python 3.6` locally
- Did steps 1 & 2 so that CI wouldn't try to read the non-existent
requirements-3.8 file from remote.
- Did step 3 so that the local `generate-requirements` command wouldn't use
the remote master to build requirements lists.
- Did steps 5 and 6 because one of the pre-commit checks indicated that I
needed to rebuild all requirements files after modifying setup.py.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
