schnie commented on a change in pull request #8777:
URL: https://github.com/apache/airflow/pull/8777#discussion_r429393752



##########
File path: chart/templates/configmap.yaml
##########
@@ -0,0 +1,108 @@
+################################
+## Airflow ConfigMap
+#################################
+apiVersion: v1
+kind: ConfigMap
+metadata:
+  name: {{ template "airflow_config" . }}
+  labels:
+    tier: airflow
+    component: config
+    release: {{ .Release.Name }}
+    chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
+    heritage: {{ .Release.Service }}
+{{- with .Values.labels }}
+{{ toYaml . | indent 4 }}
+{{- end }}
+data:
+  # These are system-specified config overrides.
+  airflow.cfg: |

Review comment:
       I envisioned this default `airflow.cfg` as a good starting point for 
this chart and that any user-specific overrides would be passed via the `env` 
field as @ashb mentioned. Mostly so that we don't need to maintain a helm value 
to airflow.cfg mapping.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to