randr97 commented on a change in pull request #8895:
URL: https://github.com/apache/airflow/pull/8895#discussion_r429670115



##########
File path: tests/providers/amazon/aws/hooks/test_s3.py
##########
@@ -313,6 +313,25 @@ def test_copy_object_acl(self, s3_bucket):
             assert ((response['Grants'][0]['Permission'] == 'FULL_CONTROL') and
                     (len(response['Grants']) == 1))
 
+    @mock_s3
+    def test_delete_bucket(self, s3_bucket):
+        # assert if the bucket is created
+        mock_hook = S3Hook()
+        mock_hook.create_bucket(bucket_name=s3_bucket)
+        assert mock_hook.check_for_bucket(bucket_name=s3_bucket)
+        # add keys to bucket
+        for i in range(0, 3):
+            mock_hook.load_file_obj(

Review comment:
       mock_hook.load_string is not getting called, this is just to load the 
data so that the delete function can be tested




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to