samuelkhtu commented on pull request #8942: URL: https://github.com/apache/airflow/pull/8942#issuecomment-633603940
> LGTM. > > One last observation about the file name `sql_branch_operator.py`. By accepting this PR Airflow will have 2 sql related operator files in the core (`check_operator.py`, `sql_branch_operator.py`) so maybe the file name should be changed `sql_branch_operator.py` -> `sql.py` so that In the future [check_operator.py](https://github.com/apache/airflow/blob/master/airflow/operators/check_operator.py) can be deprecated by move the operators into `sql.py` Similar to the deprecation of [python_operator.py](https://github.com/apache/airflow/blob/master/airflow/operators/python_operator.py) by moving classes to [python.py](https://github.com/apache/airflow/blob/master/airflow/operators/python.py) > Lets wait to see what others think of that. Thanks @eladkal. If everyone decided to merge the operators into one, shouldn't we use a separate PR instead? I am new to the community, so I am not sure what is the next step? Is there anyone I need to talk to in order to finish this PR? Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
