potiuk commented on a change in pull request #9030:
URL: https://github.com/apache/airflow/pull/9030#discussion_r431987129
##########
File path: airflow/www/app.py
##########
@@ -39,15 +39,18 @@
from airflow.utils.json import AirflowJsonEncoder
from airflow.www.static_config import configure_manifest_files
-app = None # type: Any
-appbuilder = None # type: Optional[AppBuilder]
+app: Optional[Flask] = None
csrf = CSRFProtect()
log = logging.getLogger(__name__)
+def root_app(env, resp):
+ resp(b'404 Not Found', [('Content-Type', 'text/plain')])
+ return [b'Apache Airflow is not at this location']
+
+
def create_app(config=None, testing=False, app_name="Airflow"):
- global app, appbuilder
Review comment:
Great!
##########
File path: airflow/www/app.py
##########
@@ -70,6 +73,31 @@ def create_app(config=None, testing=False,
app_name="Airflow"):
app.json_encoder = AirflowJsonEncoder
csrf.init_app(app)
+
+ def apply_middlewares(flask_app: Flask):
+ # Apply DispatcherMiddleware
+ base_url = urlparse(conf.get('webserver', 'base_url'))[2]
+ if not base_url or base_url == '/':
+ base_url = ""
+ if base_url:
+ flask_app.wsgi_app = DispatcherMiddleware( # type: ignore
Review comment:
Should we remove it then?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
