simond commented on a change in pull request #9023: URL: https://github.com/apache/airflow/pull/9023#discussion_r432387358
########## File path: tests/providers/snowflake/operators/test_snowflake_to_slack.py ########## @@ -0,0 +1,100 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from unittest.mock import Mock + +import pytest + +from airflow.models import DAG +from airflow.providers.snowflake.operators.snowflake_to_slack import ( + SlackWebhookHook, SnowflakeHook, SnowflakeToSlackOperator, +) +from airflow.utils import timezone + +TEST_DAG_ID = 'snowflake_to_slack_unit_test' +DEFAULT_DATE = timezone.datetime(2017, 1, 1) + + +@pytest.fixture +def mock_snowflake_hook_class(monkeypatch): + mocked_hook = Mock(spec=SnowflakeHook) + monkeypatch.setattr('airflow.providers.snowflake.operators.snowflake_to_slack.SnowflakeHook', mocked_hook) + return mocked_hook Review comment: Thanks for the feedback! I actually did this initially but I got the impression that Airflow was moving towards more of a pytest way of doing things with fixtures etc etc? I'm just basing this off what I read here: https://github.com/apache/airflow/blob/master/TESTING.rst#writing-unit-tests I'm pretty new to unit testing though so happy to take your lead and change this if you think it's better to use patch annotations. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
