ashb commented on a change in pull request #8739:
URL: https://github.com/apache/airflow/pull/8739#discussion_r432745457
##########
File path: tests/models/test_serialized_dag.py
##########
@@ -117,7 +116,6 @@ def test_remove_stale_dags(self):
self.assertFalse(SDM.has_dag(stale_dag.dag_id))
self.assertTrue(SDM.has_dag(fresh_dag.dag_id))
- @mock.patch('airflow.models.serialized_dag.STORE_SERIALIZED_DAGS', True)
def test_bulk_sync_to_db(self):
Review comment:
`SDM.bulk_sync_to_db` will now _always_ write to the DB when called.
Before it would return if the config was false. Now the check is moved in
to DagBag.bulk_sync:
```python
if self.store_serialized_dags:
SerializedDagModel.bulk_sync_to_db(self.dags.values())
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
