potiuk commented on a change in pull request #8265:
URL: https://github.com/apache/airflow/pull/8265#discussion_r434405021



##########
File path: scripts/ci/_utils.sh
##########
@@ -1721,3 +1748,436 @@ function run_prepare_backport_readme() {
 function get_airflow_version_from_production_image() {
      docker run --entrypoint /bin/bash "${AIRFLOW_PROD_IMAGE}" -c 'echo 
"${AIRFLOW_VERSION}"'
 }
+
+function dump_kind_logs() {

Review comment:
       While I am super happy to do it - I think I will do it in a separate 
change (right after that one is merged). I used to have such split (I believe 
all the related functions should be grouped in separate files - basically 
treated as modules in python) before but some other commiters complained that 
they should be combined. I am glad you support me with that :).
   
   But this change is  already hue and I think it's better to do it separately.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to