potiuk commented on a change in pull request #9132: URL: https://github.com/apache/airflow/pull/9132#discussion_r435292192
########## File path: scripts/ci/libraries/_remove_images.sh ########## @@ -0,0 +1,33 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Removes airflow CI and base images +function remove_all_images() { Review comment: Yeah. Push and remove were small. I combined them all into _push_pull_remove_images.sh. Since we also have _build_images.sh (and these have quite a bit more complex logic) I think it makes sense to split them this way. I also considered splitting it across prod/ci images but there are too many common parts in build to split it further. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
