nullhack commented on pull request #9165:
URL: https://github.com/apache/airflow/pull/9165#issuecomment-640481723


   > In kubernetes, you must create a file and this file will be saved to xcom.
   
   Yes, the current DockerOperator is different. It reads logs from 
`self.client.logs` instead. I think somewhere in between would be the ideal. 
The return is based on files, but the default file returned is `stdout`.
   
   > ```
   > mkdir -p /airflow/xcom/;echo '[1,2,3,4]' > /airflow/xcom/return.json
   > ```
   > 
   > In this way, the logs can still contain useful information for the 
developer.
   
   Yes, I like this approach. One problem I see is that 
`/airflow/xcom/return.json` is 
[fixed](https://github.com/apache/airflow/blob/master/airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py#L136).
 I think if the path could be changed (default `stdout`) would be more flexible.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to