rjrbt opened a new pull request #9214:
URL: https://github.com/apache/airflow/pull/9214
This is my first PR, so pardon me if I missed any steps, but this proposed
change is also _very_ simple.
The current implementation of `SystemsManagerParameterStoreBackend`
`_get_secret` uses
```python
response = self.client.get_parameter(
Name=ssm_path, WithDecryption=False
)
```
but this only allows for secrets to be stored in clear text.
This PR changes the value to `WithDecryption=True`, which is backwards
compatible with clear text values, but also supports KMS decryption in the API
call.
After reviewing the test coverage and the documentation, I don't think there
are any changes that need to be made. The are no behavior changes for users
other than this will support a storage option and will natively support tools
like [chamber cli tooling](https://github.com/segmentio/chamber)
I guess there could be an argument made to update documentation stating this
feature is now supported?
---
Make sure to mark the boxes below before creating PR: [x]
- [X] Description above provides context of the change
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Target Github ISSUE in description if exists
- [ ] Commits follow "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)"
- [] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
