jaketf commented on a change in pull request #8954:
URL: https://github.com/apache/airflow/pull/8954#discussion_r438261904
##########
File path: airflow/providers/google/cloud/operators/datafusion.py
##########
@@ -636,13 +648,15 @@ class CloudDataFusionStartPipelineOperator(BaseOperator):
template_fields = ("instance_name", "pipeline_name", "runtime_args")
@apply_defaults
- def __init__(
+ def __init__( # pylint: disable=too-many-arguments
self,
pipeline_name: str,
instance_name: str,
location: str,
runtime_args: Optional[Dict[str, Any]] = None,
+ success_states: Optional[List[str]] = None,
namespace: str = "default",
+ pipeline_timeout: int = 10 * 60,
Review comment:
The contract of this operator is to start a pipeline. not wait til
pipeline completion.
10 mins is reasonable timeout.
COMPLETED is just a success state in case it's a super quick pipeline that
completes between polls.
We can add a sensor for waiting on pipeline completion (which should use
reschedule mode if it expects to be so long).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
