ashb opened a new pull request #9222:
URL: https://github.com/apache/airflow/pull/9222


   Previously after the first parameter the colour was lost, as `color()` 
included the reset code always.
   
   I have fixed it by using `\e[22m` -- which resets the bold/thin state, but 
not the colour.
   
   Before:
   
![log-before](https://user-images.githubusercontent.com/34150/84318688-bcc0fe80-ab66-11ea-859c-bceba33ede25.png)
   
   After:
   
![logging-after](https://user-images.githubusercontent.com/34150/84318694-be8ac200-ab66-11ea-9986-f843f12eb01b.png)
   
   The "\e[22m" escape sequence has been tested on Konsole, iTerm2 and 
Terminal.app `echo -e "\033[31mHello \033[1mbold\033[22m after\033[0m"` if you 
would like to test it yourself.
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Target Github ISSUE in description if exists
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to