mik-laj commented on a change in pull request #9219:
URL: https://github.com/apache/airflow/pull/9219#discussion_r438476917
##########
File path: scripts/ci/prepare_tool_scripts.sh
##########
@@ -72,25 +132,36 @@ function prepare_terraform_script() {
cat >"${TARGET_TOOL_PATH}" <<EOF
#!/usr/bin/env bash
-docker run --rm -it \
- -v "\${HOST_AIRFLOW_SOURCES}/tmp:/tmp" \
- -v "\${HOST_AIRFLOW_SOURCES}/files:/files" \
- -v "\${HOST_AIRFLOW_SOURCES}:/opt/airflow" \
- -v "\${HOST_HOME}/.aws:/root/.aws" \
- -v "\${HOST_HOME}/.azure:/root/.azure" \
- -v "\${HOST_HOME}/.config/gcloud:/root/.config/gcloud" \
- -w /opt/airflow \
- --env-file <(env | grep TF) \
- "${IMAGE}" "\$@"
+
+DOCKER_ARGS=(
+ -v "\${HOST_AIRFLOW_SOURCES}/tmp:/tmp" \\
+ -v "\${HOST_AIRFLOW_SOURCES}/files:/files" \\
+ -v "\${HOST_AIRFLOW_SOURCES}:/opt/airflow" \\
+ -v "\${HOST_HOME}/.aws:/root/.aws" \\
+ -v "\${HOST_HOME}/.azure:/root/.azure" \\
+ -v "\${HOST_HOME}/.config/gcloud:/root/.config/gcloud" \\
+ -w /opt/airflow \\
+ --env-file <(env | grep TF) \\
+ -e GOOGLE_APPLICATION_CREDENTIALS \\
+ -e CLOUDSDK_CONFIG \\
Review comment:
Would you like each tool to have access to the credentials of other
tools? I thought that it is important to ensure that the container has access
to the credentials it needs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
