potiuk commented on a change in pull request #9223: URL: https://github.com/apache/airflow/pull/9223#discussion_r438687276
########## File path: scripts/ci/run_cli_tool.sh ########## @@ -0,0 +1,140 @@ +#!/usr/bin/env bash + +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +set -euo pipefail + +if [ -z "${AIRFLOW_CI_IMAGE}" ]; then + echo "Missing environment variable AIRFLOW_CI_IMAGE" + exit 1 +fi + +SCRIPT_NAME="$( basename "${BASH_SOURCE[0]}")" +# Drop "-update" suffix, if exists +TOOL_NAME="$(echo "${SCRIPT_NAME}" | cut -d "-" -f 1)" + +SUPPORTED_TOOL_NAMES=("aws" "az" "gcloud" "bq" "gsutil" "terraform" "java") + +if [ "$SCRIPT_NAME" == "run_cli_tool.sh" ] +then + # Direct execution - return installation script + SCRIPT_PATH=$(readlink -e "${BASH_SOURCE[0]}") + >&2 echo "# CLI tool wrappers" + >&2 echo "#" + >&2 echo "# To install, run the following command:" + >&2 echo "# source <(bash ${SCRIPT_PATH@Q})" + >&2 echo "#" + >&2 echo "" + # Print installation script + for NAME in "${SUPPORTED_TOOL_NAMES[@]}" + do + echo "ln -s ${SCRIPT_PATH@Q} /usr/bin/${NAME}" + echo "ln -s ${SCRIPT_PATH@Q} /usr/bin/${NAME}-update" + echo "chmod +x /usr/bin/${NAME} /usr/bin/${NAME}-update" + done + exit 0 +fi + +COMMON_DOCKER_ARGS=( + -v "${HOST_AIRFLOW_SOURCES}/tmp:/tmp" + -v "${HOST_AIRFLOW_SOURCES}/files:/files" + -v "${HOST_AIRFLOW_SOURCES}:/opt/airflow" + --env-file <(env) +) + +AWS_CREDENTIALS_DOCKER_ARGS=(-v "${HOST_HOME}/.aws:/root/.aws") +AZURE_CREDENTIALS_DOCKER_ARGS=(-v "${HOST_HOME}/.azure:/root/.azure") +GOOGLE_CREDENTIALS_DOCKER_ARGS=(-v "${HOST_HOME}/.config/gcloud:/root/.config/gcloud") + +DIRECTORIES_TO_FIX=('/tmp/' '/files/') + +COMMAND=("${@}") + +# Configure selected tool +case "${TOOL_NAME}" in + aws ) + COMMON_DOCKER_ARGS+=("${AWS_CREDENTIALS_DOCKER_ARGS[@]}") + DIRECTORIES_TO_FIX+=("${HOST_HOME}/.aws") + IMAGE_NAME="amazon/aws-cli:latest" + ;; + az ) + COMMON_DOCKER_ARGS+=("${AZURE_CREDENTIALS_DOCKER_ARGS[@]}") + DIRECTORIES_TO_FIX+=("${HOST_HOME}/.azure") + IMAGE_NAME="mcr.microsoft.com/azure-cli:latest" + ;; + gcloud | bq | gsutil ) + COMMON_DOCKER_ARGS+=("${GOOGLE_CREDENTIALS_DOCKER_ARGS[@]}") + DIRECTORIES_TO_FIX+=("${HOST_HOME}/.config/gcloud") + IMAGE_NAME="gcr.io/google.com/cloudsdktool/cloud-sdk:latest" + COMMAND=("$TOOL_NAME" "${@}") + ;; + terraform ) + COMMON_DOCKER_ARGS+=("${GOOGLE_CREDENTIALS_DOCKER_ARGS[@]}") + COMMON_DOCKER_ARGS+=("${AZURE_CREDENTIALS_DOCKER_ARGS[@]}") + COMMON_DOCKER_ARGS+=("${AWS_CREDENTIALS_DOCKER_ARGS[@]}") + COMMON_DOCKER_ARGS+=(-w /opt/airflow) + DIRECTORIES_TO_FIX+=( + "${HOST_HOME}/.config/gcloud" + "${HOST_HOME}/.aws" + "${HOST_HOME}/.azure" + ) + IMAGE_NAME="hashicorp/terraform:latest" + ;; + java ) + # TODO: Should we add other credentials? + COMMON_DOCKER_ARGS+=("${GOOGLE_CREDENTIALS_DOCKER_ARGS[@]}") + DIRECTORIES_TO_FIX+=("${HOST_HOME}/.config/gcloud") + IMAGE_NAME="openjdk:8-jre-slim" + COMMAND=("/usr/local/openjdk-8/bin/java" "${@}") + ;; + * ) + >&2 echo "Unsupported tool name: ${TOOL_NAME}" + exit 1 + ;; +esac + +# Run update, if requested +if [[ "${SCRIPT_NAME}" == *-update ]]; then + docker pull "${IMAGE_NAME}" + exit $? +fi + +# Otherwise, run tool +TOOL_DOCKER_ARGS=(--rm --interactive) +TOOL_DOCKER_ARGS+=("${COMMON_DOCKER_ARGS[@]}") + +if [ -t 0 ] ; then + TOOL_DOCKER_ARGS+=( + --tty + ) +fi + +docker run "${TOOL_DOCKER_ARGS[@]}" "${IMAGE_NAME}" "${COMMAND[@]}" + +RES=$? + +# Set file permissions to the host user +if [[ "${HOST_OS}" == "Linux" ]]; then + FIX_DOCKER_ARGS=(--rm) + FIX_DOCKER_ARGS+=("${COMMON_DOCKER_ARGS[@]}") + FIX_COMMAND=(bash -c + "find ${DIRECTORIES_TO_FIX[@]@Q} -user root -print0 | xargs --null chown '${HOST_USER_ID}.${HOST_GROUP_ID}' --no-dereference") + + docker run "${FIX_DOCKER_ARGS[@]}" "${AIRFLOW_CI_IMAGE}" "${FIX_COMMAND[@]}" >/dev/null 2>&1 Review comment: > > Why /root/ here ? The volumes are mapped from host not from the container because we are using the same engine that is in the host > > We use these paths to determine which directories to fix, but we do it in the container, so we need to use the path from the container. Saying differently, these paths are used in scripts that run in the container. Once we run it no via another container (I need some rest) - then yes ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
