potiuk commented on a change in pull request #9230:
URL: https://github.com/apache/airflow/pull/9230#discussion_r438703894
##########
File path: .github/workflows/ci.yml
##########
@@ -210,6 +210,11 @@ jobs:
run: ./scripts/ci/ci_perform_kind_cluster_operation.sh start
- name: "Deploy app to cluster"
run: ./scripts/ci/ci_deploy_app_to_kubernetes.sh
+ - uses: actions/upload-artifact@v2
+ if: failure()
Review comment:
One small comment. It would be worth while to remove the if here. Those
log might be useful to compare and see success vs. failure. And it does not
cost us to have them also on success.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
