ephraimbuddy commented on a change in pull request #9227:
URL: https://github.com/apache/airflow/pull/9227#discussion_r438905129
##########
File path: tests/api_connexion/endpoints/test_event_log_endpoint.py
##########
@@ -29,17 +34,177 @@ def setUpClass(cls) -> None:
def setUp(self) -> None:
self.client = self.app.test_client() # type:ignore
+ with create_session() as session:
+ session.query(Log).delete()
+ self.default_time = "2020-06-10T20:36:40.186116+00:00"
+ self.default_time = '2020-06-11T07:04:57.501393+00:00'
+
+ def tearDown(self) -> None:
+ with create_session() as session:
+ session.query(Log).delete()
+
+ def _create_task_instance(self):
+ dag = DAG('TEST_DAG_ID', start_date=timezone.parse(self.default_time),
+ end_date=timezone.parse(self.default_time))
+ op1 = DummyOperator(task_id="TEST_TASK_ID", owner="airflow",
+ )
+ dag.add_task(op1)
+ ti = TaskInstance(task=op1,
execution_date=timezone.parse(self.default_time))
+ return ti
class TestGetEventLog(TestEventLogEndpoint):
- @pytest.mark.skip(reason="Not implemented yet")
- def test_should_response_200(self):
- response = self.client.get("/api/v1/eventLogs/1")
+
+ @provide_session
+ def test_should_response_200(self, session):
+ log_model = Log(
+ event='TEST_EVENT',
+ task_instance=self._create_task_instance(),
+ )
+ log_model.dttm = timezone.parse(self.default_time)
+ session.add(log_model)
+ session.commit()
+ event_log_id = log_model.id
+ response = self.client.get(f"/api/v1/eventLogs/{event_log_id}")
assert response.status_code == 200
+ self.assertEqual(
+ response.json,
+ {
+ "event_log_id": event_log_id,
+ "event": "TEST_EVENT",
+ "dag_id": "TEST_DAG_ID",
+ "task_id": "TEST_TASK_ID",
+ "execution_date": self.default_time,
+ "owner": 'airflow',
+ "when": self.default_time,
+ "extra": None
+ }
+ )
+
+ def test_should_response_404(self):
+ response = self.client.get("/api/v1/eventLogs/1")
+ assert response.status_code == 404
+ self.assertEqual(
+ {'detail': None, 'status': 404, 'title': 'Event Log not found',
'type': 'about:blank'},
+ response.json
+ )
class TestGetEventLogs(TestEventLogEndpoint):
- @pytest.mark.skip(reason="Not implemented yet")
- def test_should_response_200(self):
+
+ @provide_session
+ def test_should_response_200(self, session):
+ log_model_1 = Log(
+ event='TEST_EVENT_1',
+ task_instance=self._create_task_instance(),
+ )
+ log_model_2 = Log(
+ event='TEST_EVENT_2',
+ task_instance=self._create_task_instance(),
+ )
+ log_model_1.dttm = timezone.parse(self.default_time)
+ log_model_2.dttm = timezone.parse(self.default_time)
Review comment:
```suggestion
log_model_2.dttm = timezone.parse(self.default_time_2)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
