ashb commented on a change in pull request #9044:
URL: https://github.com/apache/airflow/pull/9044#discussion_r439071101
##########
File path: airflow/providers/apache/spark/hooks/spark_submit.py
##########
@@ -617,6 +617,13 @@ def on_kill(self):
self._submit_sp.kill()
if self._yarn_application_id:
+ if self._keytab is not None and self._principal is not None:
+ kinit_cmd = "kinit -kt {} {}" \
+ .format(self._keytab, self._principal).split()
+ kinit = subprocess.Popen(kinit_cmd,
+ stdout=subprocess.PIPE,
+ stderr=subprocess.PIPE)
Review comment:
This change looks good, but can you add a comment to the nrew_from_kt
call in SparkOperator to say why we aren't treating the errors as fatal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
