tanjinP commented on pull request #8809: URL: https://github.com/apache/airflow/pull/8809#issuecomment-643042061
> > I added a new example, would this break anything? I know for sure it will not run as some of the arguments were made up. I know the CI would catch this if anything is wrong, but those checks are still running at the time of this message. > > Our system tests are not automatically launched, but the reviewer should run the system tests manually before merging this change to fully verify that it is valid. We plan to run these CI tests in the near future, but this is not happening yet. In this case, it will be a problem because this dataflow will never end. In this Q I would like to prepare operators that will stop such a jobs using Airflow. For now, you could add new step in tearDown method. To stop jobs, you can use `gcloud` command. @mik-laj I’ve checked the [system tests guide](https://github.com/apache/airflow/blob/master/TESTING.rst#airflow-system-tests) and it looks like there aren’t any Dataflow ones based on the `git grep @pytest.mark.system("google.cloud”)` check I’ve done so I think this should be fine. Let me know if not. Anything else to look at for this PR? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
