ephraimbuddy commented on a change in pull request #9273: URL: https://github.com/apache/airflow/pull/9273#discussion_r439773896
########## File path: airflow/api_connexion/endpoints/variable_endpoint.py ########## @@ -14,41 +14,76 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. +from typing import Optional -# TODO(mik-laj): We have to implement it. -# Do you want to help? Please look at: https://github.com/apache/airflow/issues/8142 +from flask import Response, make_response, request +from marshmallow import ValidationError +from airflow.api_connexion.exceptions import BadRequest, NotFound +from airflow.api_connexion.schemas.variable_schema import variable_collection_schema, variable_schema +from airflow.models import Variable +from airflow.utils.session import provide_session -def delete_variable(): + +def delete_variable(variable_key: str) -> Response: """ Delete variable """ - raise NotImplementedError("Not implemented yet.") + Variable.delete(variable_key) + return make_response('', 204) -def get_variable(): +def get_variable(variable_key: str) -> Response: """ Get a variables by key """ - raise NotImplementedError("Not implemented yet.") + try: + var = Variable.get(variable_key) + except KeyError: + raise NotFound("Variable not found") + return variable_schema.dump({"key": variable_key, "val": var}) -def get_variables(): +@provide_session +def get_variables(session, limit: Optional[int], offset: Optional[int] = None) -> Response: """ Get all variable values """ - raise NotImplementedError("Not implemented yet.") + query = session.query(Variable) + if limit: + if offset: + query = query.offset(offset * limit) + query = query.limit(limit) + variables = query.all() Review comment: `offset * limit` is not working correctly. I didn't see any issue when I used `query.offset(offset).limit(limit)`, I suggest you add a test that `query.offset(offset).limit(limit)` cannot pass. What do you suggest? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
