aneesh-joseph commented on a change in pull request #8777:
URL: https://github.com/apache/airflow/pull/8777#discussion_r441042114



##########
File path: chart/templates/configmap.yaml
##########
@@ -0,0 +1,108 @@
+################################
+## Airflow ConfigMap
+#################################
+apiVersion: v1
+kind: ConfigMap
+metadata:
+  name: {{ template "airflow_config" . }}
+  labels:
+    tier: airflow
+    component: config
+    release: {{ .Release.Name }}
+    chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
+    heritage: {{ .Release.Service }}
+{{- with .Values.labels }}
+{{ toYaml . | indent 4 }}
+{{- end }}
+data:
+  # These are system-specified config overrides.
+  airflow.cfg: |

Review comment:
       @schnie @ashb  a follow up question on this one. `.Values.env` will work 
for scheduler, webserver and workers when we use the `CeleryExecutor` , but how 
is it handled when user opts for   `KubernetesExecutor` ? the configmap doesn't 
seem to update `[kubernetes_environment_variables]` section of `airflow.cfg` 
with  the custom environment variables set by the user




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to