mik-laj commented on a change in pull request #9354:
URL: https://github.com/apache/airflow/pull/9354#discussion_r441850813



##########
File path: airflow/www/templates/airflow/dag.html
##########
@@ -366,9 +366,9 @@ <h4 class="modal-title" id="dagModalLabel">
     var task_id = '';
     var execution_date = '';
     var subdag_id = '';
-    var show_es_logs = false;
-    {% if show_external_logs is defined %}
-      show_es_logs = '{{ show_external_logs }}' == "True";
+    var show_remote_log_redirect = false;

Review comment:
       ```suggestion
       var show_external_log_redirect = false;
   ```
   This name is even more confusing here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to