mik-laj commented on a change in pull request #9397:
URL: https://github.com/apache/airflow/pull/9397#discussion_r443017078
##########
File path: airflow/www/utils.py
##########
@@ -39,23 +39,28 @@
from airflow.www.forms import DateTimeWithTimezoneField
from airflow.www.widgets import AirflowDateTimePickerWidget
-DEFAULT_SENSITIVE_VARIABLE_FIELDS = (
+DEFAULT_SENSITIVE_VARIABLE_FIELDS = {
'password',
'secret',
'passwd',
'authorization',
'api_key',
'apikey',
'access_token',
-)
+}
def should_hide_value_for_key(key_name):
# It is possible via importing variables from file that a key is empty.
if key_name:
- config_set = conf.getboolean('admin',
- 'hide_sensitive_variable_fields')
- field_comp = any(s in key_name.lower() for s in
DEFAULT_SENSITIVE_VARIABLE_FIELDS)
+ config_set = conf.getboolean('admin', 'hide_sensitive_variable_fields')
+
+ sensitive_variable_fields = conf.get('admin',
'sensitive_variable_fields')
+
+ if sensitive_variable_fields:
+
DEFAULT_SENSITIVE_VARIABLE_FIELDS.update(sensitive_variable_fields.split(','))
Review comment:
This will cause this variable to be updated each time this method is
called. I think it's enough for this to happen only once.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
