potiuk commented on a change in pull request #9421:
URL: https://github.com/apache/airflow/pull/9421#discussion_r443114210
##########
File path: airflow/www/forms.py
##########
@@ -129,23 +143,84 @@ class DagRunForm(DynamicForm):
lazy_gettext('External Trigger'))
conf = TextAreaField(
lazy_gettext('Conf'),
- validators=[ValidJson(), validators.Optional()],
+ validators=[ValidJson(), Optional()],
widget=BS3TextAreaFieldWidget())
def populate_obj(self, item):
- super().populate_obj(item)
+ """Populates the attributes of the passed obj with data from the
form’s fields."""
+ super().populate_obj(item) # pylint: disable=no-member
item.run_type = DagRunType.from_run_id(item.run_id).value
if item.conf:
item.conf = json.loads(item.conf)
+_connection_types = [
Review comment:
Nice. This is exactly where it belongs!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
