mik-laj commented on a change in pull request #9431:
URL: https://github.com/apache/airflow/pull/9431#discussion_r443191107
##########
File path: tests/api_connexion/endpoints/test_connection_endpoint.py
##########
@@ -181,17 +182,42 @@ def test_handle_limit_offset(self, url,
expected_conn_ids, session):
self.assertEqual(conn_ids, expected_conn_ids)
@provide_session
- def test_should_respect_page_size_limit(self, session):
+ def test_should_respect_page_size_limit_default(self, session):
connection_models = self._create_connections(200)
session.add_all(connection_models)
session.commit()
- response = self.client.get("/api/v1/connections?limit=150")
+ response = self.client.get("/api/v1/connections")
assert response.status_code == 200
self.assertEqual(response.json["total_entries"], 200)
self.assertEqual(len(response.json["connections"]), 100)
+ @provide_session
+ @mock.patch("airflow.api_connexion.parameters.conf.get")
Review comment:
Can you use conf_vars decorator here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
