mik-laj commented on a change in pull request #9331: URL: https://github.com/apache/airflow/pull/9331#discussion_r443193574
########## File path: airflow/api_connexion/endpoints/log_endpoint.py ########## @@ -15,12 +15,93 @@ # specific language governing permissions and limitations # under the License. -# TODO(mik-laj): We have to implement it. -# Do you want to help? Please look at: https://github.com/apache/airflow/issues/8135 +from flask import Response, current_app, request +from itsdangerous.exc import BadSignature +from itsdangerous.url_safe import URLSafeSerializer -def get_log(): +from airflow.api_connexion.exceptions import BadRequest, NotFound +from airflow.api_connexion.schemas.log_schema import logs_schema +from airflow.models import DagRun +from airflow.utils.log.log_reader import TaskLogReader +from airflow.utils.session import provide_session + + +@provide_session +def get_log(session, dag_id, dag_run_id, task_id, task_try_number, + full_content=False, token=None): """ Get logs for specific task instance """ - raise NotImplementedError("Not implemented yet.") + if not token: + metadata = {} + else: + key = current_app.config["SECRET_KEY"] + try: + metadata = URLSafeSerializer(key).loads(token) + except BadSignature: + raise BadRequest("Bad Signature. Please sign your token with URLSafeSerializer") + + if metadata.get('download_logs', None) and metadata['download_logs']: + full_content = True + + if full_content: + metadata['download_logs'] = True + else: + metadata['download_logs'] = False + + task_log_reader = TaskLogReader() + if not task_log_reader.is_supported: + metadata = {"end_of_log": True} + return logs_schema.dump(dict( Review comment: Can you use NamedTuple istead of dict? This will allow us to preserve types, so we will validate them by mypy. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
