nullhack commented on pull request #9464: URL: https://github.com/apache/airflow/pull/9464#issuecomment-647127052
@mik-laj @akki I closed accidentally the other PR. Then I cleaned up things and put on this new. Can you review It again? About your questions: I added the example on `airflow/providers/docker/example_dags/example_docker_xcom.py` The reviews about `wait` and memory usage are correct. I did not considered huge containers running and capturing outputs on last PR. This one I used generators and deque to read last line [efficiently](https://stackoverflow.com/questions/2138873/cleanest-way-to-get-last-item-from-python-iterator). I decided to keep the warnings together with stdout on airflow logs, but save only stdout on xcom to solve the issue 3. The `stop` was an issue due to running `wait` before the functions. I shifted `wait` to It's right place and removed the `stop`. Thanks @akki for spotting that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
