mik-laj opened a new pull request #9467: URL: https://github.com/apache/airflow/pull/9467
This is a DRAFT and I still have to complete the missing documentation and unit tests. I wanted to prepare a minimal valuable product for the upgrade_check command. Only one rule is implemented, but I think that's enough to show the feature. In the next steps, we can think about what rules we need to create, create tickets, and then work on the next rules by the whole community. Recently, we have a lot of new beginner contributors and I think we can try to engage them for this task. Most rules will be small and independent, so they will be great candidates for good-first-issue. An example of the result of this command is presented in the termianlshot below <img width="479" alt="Screenshot 2020-06-13 at 12 58 38" src="https://user-images.githubusercontent.com/12058428/84566968-a63cc200-ad75-11ea-870b-60d07d0c44fa.png";> Example JSON: ``` [ { "rule": "ConnTypeIsNotNullableRule", "message": "Connection<id=''\", conn_id=AA> have empty conn_type field." } ] ``` Part of: https://github.com/apache/airflow/issues/8765 Continuation of the change, but for 1.10: https://github.com/apache/airflow/pull/9276 --- Make sure to mark the boxes below before creating PR: [x] - [X] Description above provides context of the change - [X] Unit tests coverage for changes (not needed for documentation changes) - [X] Target Github ISSUE in description if exists - [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)" - [X] Relevant documentation is updated including usage instructions. - [XI will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example). --- In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md). Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
![https://user-images.githubusercontent.com/12058428/84566968-a63cc200-ad75-11ea-870b-60d07d0c44fa.png"](https://user-images.githubusercontent.com/12058428/84566968-a63cc200-ad75-11ea-870b-60d07d0c44fa.png"){kind=link}