zikun commented on pull request #9497: URL: https://github.com/apache/airflow/pull/9497#issuecomment-649472645
I fixed the json test. Now there's only one pylint test failing > tests/api_connexion/endpoints/test_config_endpoint.py:45:8: W0201: Attribute 'client' defined outside __init__ (attribute-defined-outside-init) I converted unittest to pytest as I remember there was a discussion to move away from unittest to pytest. Can I make `client` a class attribute by moving it to `setup_class()`? Was there any reason to put it in `setUp()` rather than `setUpClass()` for unittest? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
