BasPH opened a new pull request #8745: URL: https://github.com/apache/airflow/pull/8745
FAB supports authentication with LDAP, but running it with Python 3 gives an error: "Exception: No ldap library for python.". FAB does not install an LDAP library, the user of FAB has to install it himself. This PR installs `python-ldap` when installing Airflow with the `ldap` extra. This PR: 1. Removes the ldap3 library which was used in the old auth_ldap module (removed in https://github.com/apache/airflow/commit/3a7b741ab9ed0937571c77a10b5d244f14eaf7db) 2. Installs python-ldap (see [1](https://gitter.im/dpgaspar/Flask-AppBuilder?at=5cf4fc56cea8295279e53fce), [2](https://github.com/dpgaspar/Flask-AppBuilder/issues/200#issuecomment-128173774), [3](https://github.com/dpgaspar/Flask-AppBuilder/issues/806#issuecomment-421334361)) Don't think we need to add tests here since it's more of a FAB thing than an Airflow thing. --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests coverage for changes (not needed for documentation changes) - [x] Target Github ISSUE in description if exists - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)" - [x] Relevant documentation is updated including usage instructions. - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example). --- In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md). Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
