efolgar commented on a change in pull request #9566:
URL: https://github.com/apache/airflow/pull/9566#discussion_r447129143
##########
File path:
airflow/providers/google/marketing_platform/operators/campaign_manager.py
##########
@@ -298,6 +299,12 @@ def __init__(
self.gcp_conn_id = gcp_conn_id
self.delegate_to = delegate_to
+ def prepare_template(self) -> None:
+ # If .json is passed then we have to read the file
+ if isinstance(self.report, str) and self.report.endswith('.json'):
Review comment:
True, although you can't take advantage of Airflow's [built-in
macros](https://airflow.apache.org/docs/stable/macros-ref.html) like
task_instance. Also deviates from the behavior of other templated operators
(e.g.
[BashOperator](https://github.com/apache/airflow/blob/master/airflow/operators/bash.py)).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]