ephraimbuddy commented on a change in pull request #9556:
URL: https://github.com/apache/airflow/pull/9556#discussion_r448256015
##########
File path: airflow/api_connexion/schemas/dag_run_schema.py
##########
@@ -72,5 +72,25 @@ class DAGRunCollectionSchema(Schema):
total_entries = fields.Int()
+class DagRunsBatchFormSchema(Schema):
+ """ Schema to validate and deserialize the Form(request payload) submitted
to DagRun Batch endpoint"""
+
+ class Meta:
+ """ Meta """
+ datetimeformat = 'iso'
+ strict = True
+
+ page_offset = fields.Int(required=False, missing=0, min=0)
+ page_limit = fields.Int(required=False, missing=100, min=1)
+ dag_ids = fields.List(fields.Str(), required=False, missing=None)
+ execution_date_gte = fields.DateTime(required=False, missing=None)
Review comment:
```suggestion
execution_date_gte = fields.DateTime()
```
I suggest you remove the missing and required args. To only use them when
the value should be something other than False and None respectively. This is
already the default from marshmallow.
https://marshmallow.readthedocs.io/en/2.x-line/api_reference.html#module-marshmallow.fields
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
