ephraimbuddy commented on a change in pull request #9503:
URL: https://github.com/apache/airflow/pull/9503#discussion_r448607998
##########
File path: airflow/api_connexion/endpoints/dag_run_endpoint.py
##########
@@ -69,24 +61,24 @@ def get_dag_runs(session, dag_id, start_date_gte=None,
start_date_lte=None,
# filter start date
if start_date_gte:
- query = query.filter(DagRun.start_date >= start_date_gte)
+ query = query.filter(DagRun.start_date >=
timezone.parse(start_date_gte))
Review comment:
I personally like the `format_datetime` approach for a few reasons. One
is that we was able to take datetime from url without parsing with quote_plus.
Another was that we didn't parse with timezone.parse in view code.
However, I would suggest we use custom date format in spec for those areas
we need to use `format_datetime`. The reason is that connection may add the
`rfc3339-validator` and it would affect us if it gets installed with a new
version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
