houqp commented on a change in pull request #1:
URL: https://github.com/apache/airflow-client-go/pull/1#discussion_r448693291



##########
File path: README.md
##########
@@ -1 +1,62 @@
-# Airflow API Client for Go
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements.  See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership.  The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License.  You may obtain a copy of the License at
+
+   http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied.  See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+Airflow Go client
+=================
+
+Go Airflow OpenAPI client generated from [openapi 
spec](https://github.com/apache/airflow/tree/master/clients).

Review comment:
       @turbaszek I updated the link to point to 
`https://github.com/apache/airflow/blob/master/clients/gen/go.sh`, which will 
be a valid link once https://github.com/apache/airflow/pull/9502 gets merged. I 
think linking to the actual automation script might be better here since there 
is no guarantee that future of the client will be generated using the same 
v1.yaml spec. It also provides more context to users on how this client is 
actually generated so it's easier for them to contribute change back to the 
airflow repo.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to