kaxil commented on pull request #9647:
URL: https://github.com/apache/airflow/pull/9647#issuecomment-653644916


   On the flip side changes in the Helm Chart should not affect Airflow's CI. 
In this case, the default of disabling API should just be a change in Airflow 
and should not be a change in the Helm chart version until a new Airflow 
version is released.
   
   > Having a dedicated config is much nicer solution. And if we were to do 
this for split repos we would have to implement "workaround" first, "good 
solution" in a chart repo, release the repo and finally implement a "good" 
solution. I am sure it is not worth it and I love how kubernetes team solved it.
   
   We already have a dedicated config `default_test.cfg` 
(https://github.com/apache/airflow/blob/master/airflow/config_templates/default_test.cfg)
 we should be using that for tests.
   
   I don't see a need of "workaround" here?
   
   Btw I am not against the Kubernetes way, I will look into the details and 
let you'll know on the thread. But as of now I am still on the "separate repo" 
side


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to