turbaszek commented on a change in pull request #9472:
URL: https://github.com/apache/airflow/pull/9472#discussion_r449756748
##########
File path: tests/providers/apache/hive/hooks/test_hive.py
##########
@@ -383,6 +383,10 @@ def test_table_exists(self):
self.hook.table_exists(str(random.randint(1, 10000)))
)
+ def test_drop_partition(self):
+ self.assertTrue(self.hook.drop_partitions(self.table, db=self.database,
+ part_vals=[DEFAULT_DATE_DS]))
+
Review comment:
Side effects in tests are not a good practise and Airflow already has
number of flaky tests. So I would be in favor of using mocking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
