potiuk commented on a change in pull request #9670:
URL: https://github.com/apache/airflow/pull/9670#discussion_r449911768



##########
File path: airflow/migrations/env.py
##########
@@ -21,7 +21,7 @@
 from alembic import context
 
 from airflow import models, settings
-from airflow.models.serialized_dag import SerializedDagModel  # noqa
+from airflow.models.serialized_dag import SerializedDagModel  # pylint: 
disable=unused-import # noqa

Review comment:
       Possibly we even need to add more here (from airflow.utils.db). Possibly 
one place where we import one modes?:
   
   ```
   from airflow.models import (  # noqa: F401 # pylint: disable=unused-import
       DAG, XCOM_RETURN_KEY, BaseOperator, BaseOperatorLink, Connection, 
DagBag, DagModel, DagPickle, DagRun,
       DagTag, Log, Pool, SkipMixin, SlaMiss, TaskFail, TaskInstance, 
TaskReschedule, Variable, XCom,
   )
   # We need to add this model manually to get reset working well
   # noinspection PyUnresolvedReferences
   from airflow.models.serialized_dag import SerializedDagModel  # noqa: F401  
# pylint: disable=unused-import
   ```
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to