turbaszek commented on a change in pull request #9685:
URL: https://github.com/apache/airflow/pull/9685#discussion_r450087435
##########
File path: breeze
##########
@@ -228,62 +228,80 @@ function initialize_virtualenv() {
# Sets up autocomplete for Breeze for both - bash and zsh
function setup_autocomplete() {
echo "Installing bash/zsh completion for local user"
- echo "Note that completion for zsh is just limited to flags - without
their values"
echo
- echo
- set +e
- grep ".bash_completion.d" "${HOME}/.bashrc" >/dev/null 2>&1
- RES=$?
- set -e
- if [[ "${RES}" == "0" ]]; then
- echo >&2
- echo >&2 "ERROR: Bash completion already setup before."
- echo >&2
- exit 1
- fi
"${AIRFLOW_SOURCES}/confirm" "This will create ~/.bash_completion.d/
directory and modify ~/.*rc files"
echo
echo
mkdir -pv ~/.bash_completion.d
ln -sf "${AIRFLOW_SOURCES}/breeze-complete" "${HOME}/.bash_completion.d/"
- touch ~/.bashrc
- cat >>~/.bashrc <<"EOF"
+ echo
+ echo "Breeze Bash completion is linked to:
${AIRFLOW_SOURCES}/breeze-complete now."
Review comment:
```suggestion
echo "Breeze Bash completion is now linked to:
${AIRFLOW_SOURCES}/breeze-complete"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
