coopergillan commented on a change in pull request #9517:
URL: https://github.com/apache/airflow/pull/9517#discussion_r450897421
##########
File path: airflow/providers/amazon/aws/operators/athena.py
##########
@@ -28,9 +28,6 @@ class AWSAthenaOperator(BaseOperator):
"""
An operator that submit presto query to athena.
- If ``do_xcom_push`` is True, the QueryExecutionID assigned to the
- query will be pushed to an XCom when it successfuly completes.
Review comment:
[Here is the setting in `BaseOperator` on
`master`](https://github.com/apache/airflow/blob/eb403beea2d1035635b7bea24c49b6b964313e51/airflow/models/baseoperator.py#L359).
Since operator docstrings usually do not mention super class functionality, I
think this could be removed. The behavior should be evident by looking at the
super class and understanding that `query_execution_id` is the value in
question that will or will not be xcom_pushed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
