turbaszek commented on pull request #9712: URL: https://github.com/apache/airflow/pull/9712#issuecomment-655541034
> LGTM overall, but I noticed that you usually refer to instances of `TaskInstanceKeyType` as `key`, but in airflow/jobs/backfill_job.py you use `ti_key` and `ti` in airflow/models/taskinstance.py. What would you say about introducing some convention for variable name referring to `TaskInstanceKeyType`, just like `TaskInstance` is usually referred to as `ti`? Personally, I like `ti_key`. @olchas I would propose to use `ti_key` and `tik` for short. WDYT? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
