turbaszek commented on a change in pull request #9756:
URL: https://github.com/apache/airflow/pull/9756#discussion_r453182785



##########
File path: tests/models/test_dag.py
##########
@@ -1355,6 +1355,56 @@ def 
test_create_dagrun_run_type_is_obtained_from_run_id(self):
         dr = dag.create_dagrun(run_id="custom_is_set_to_manual", 
state=State.NONE)
         assert dr.run_type == DagRunType.MANUAL.value
 
+    def test_clear_reset_dagruns(self):
+        dag_id = 'test_clear_dag_reset_dagruns'
+        self._clean_up(dag_id)
+        task_id = 't1'
+        dag = DAG(dag_id, start_date=DEFAULT_DATE, max_active_runs=1)
+        t_1 = DummyOperator(task_id=task_id, dag=dag)
+
+        session = settings.Session()
+        dagrun_1 = dag.create_dagrun(
+            run_type=DagRunType.BACKFILL_JOB,
+            state=State.RUNNING,
+            start_date=DEFAULT_DATE,
+            execution_date=DEFAULT_DATE,
+        )
+        session.merge(dagrun_1)
+
+        task_instance_1 = TI(t_1, execution_date=DEFAULT_DATE, 
state=State.RUNNING)
+        session.merge(task_instance_1)
+        session.commit()

Review comment:
       Would you mind using `create_session` ctx manager?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to