anikarni opened a new pull request #9817: URL: https://github.com/apache/airflow/pull/9817
I had a use for this sensor in project work, so I figured I'd contribute it to the repo. The S3UploadSessionCompleteSensor is essentially the same implementation as exists for GCS. The only things that changes is the hook call. The S3UploadSessionCompleteSensor polls the number of files in a S3 bucket and verifies against the previous count. If the count does not change for a given interval, the sensor succeeds. Since the logic for the sensor is the same as GCS, I considered refactoring for code reuse, but I don't exactly know what the plans are for separating provider operators into self-contained packages, so I opted for duplicating the code. Feel free to suggest an alternative approach if this does not seem adequate. Thanks! --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests coverage for changes (not needed for documentation changes) - [x] Target Github ISSUE in description if exists - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)" - [x] Relevant documentation is updated including usage instructions. - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example). --- In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md). Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
