casassg commented on a change in pull request #9631:
URL: https://github.com/apache/airflow/pull/9631#discussion_r455418070
##########
File path: airflow/models/taskinstance.py
##########
@@ -1132,7 +1133,8 @@ def signal_handler(signum, frame): # pylint:
disable=unused-argument
self._run_execute_callback(context, task)
# Execute the task
- result = self._execute_task(context, task_copy)
+ with set_current_context(context):
Review comment:
Yup agree to that. Also, we are modifying task instance due to this
being the best module to set the current context (as it's the wrapper for any
operator execution.
Regarding wrapping pre_execute/post_execute, we could discuss this but I
think it should be fine for now to keep it at execute (and make sure we write
docs about this)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
