aneesh-joseph commented on a change in pull request #9816:
URL: https://github.com/apache/airflow/pull/9816#discussion_r455504042



##########
File path: chart/values.yaml
##########
@@ -437,9 +437,87 @@ postgresql:
   postgresqlPassword: postgres
   postgresqlUsername: postgres
 
-# Authentication backend used for the experimental API
-api:
-  authBackend: airflow.api.auth.backend.deny_all
+# Config settings to go into the mounted airflow.cfg
+#
+# Please note that these values are passed through the `tpl` function, so are
+# all subject to being rendered as go templates. If you need to include a
+# litera `{{` in a value, it must be expessed like this:
+#
+#    a: '{{ "{{ not a template }}" }}'
+#
+# yamllint disable rule:line-length
+config:
+  core:
+    dags_folder: '{{ include "airflow_dags" . }}'
+    load_examples: 'False'
+    colored_console_log: 'False'
+    executor: '{{ .Values.executor }}'
+    remote_logging: '{{- ternary "True" "False" .Values.elasticsearch.enabled 
}}'
+  # Authentication backend used for the experimental API
+  api:
+    auth_backend: airflow.api.auth.backend.deny_all
+  logging:
+    logging_level: DEBUG
+  webserver:
+    enable_proxy_fix: 'True'
+    expose_config: 'True'
+    rbac: 'True'
+
+  celery:
+    default_queue: celery
+
+  scheduler:
+    scheduler_heartbeat_sec: 5
+    statsd_on: '{{- if .Values.statsd.enabled }}true{{ else }}false{{ end }}'

Review comment:
       ```suggestion
       statsd_on: '{{ ternary "True" "False" .Values.statsd.enabled }}'
   ```

##########
File path: chart/values.yaml
##########
@@ -437,9 +437,87 @@ postgresql:
   postgresqlPassword: postgres
   postgresqlUsername: postgres
 
-# Authentication backend used for the experimental API
-api:
-  authBackend: airflow.api.auth.backend.deny_all
+# Config settings to go into the mounted airflow.cfg
+#
+# Please note that these values are passed through the `tpl` function, so are
+# all subject to being rendered as go templates. If you need to include a
+# litera `{{` in a value, it must be expessed like this:
+#
+#    a: '{{ "{{ not a template }}" }}'
+#
+# yamllint disable rule:line-length
+config:
+  core:
+    dags_folder: '{{ include "airflow_dags" . }}'
+    load_examples: 'False'
+    colored_console_log: 'False'
+    executor: '{{ .Values.executor }}'
+    remote_logging: '{{- ternary "True" "False" .Values.elasticsearch.enabled 
}}'
+  # Authentication backend used for the experimental API
+  api:
+    auth_backend: airflow.api.auth.backend.deny_all
+  logging:
+    logging_level: DEBUG
+  webserver:
+    enable_proxy_fix: 'True'
+    expose_config: 'True'
+    rbac: 'True'
+
+  celery:
+    default_queue: celery
+
+  scheduler:
+    scheduler_heartbeat_sec: 5
+    statsd_on: '{{- if .Values.statsd.enabled }}true{{ else }}false{{ end }}'
+    statsd_port: 9125
+    statsd_prefix: airflow
+    statsd_host: '{{ printf "%s-statsd" .Release.Name }}'
+
+    # Restart Scheduler every 41460 seconds (11 hours 31 minutes)
+    # The odd time is chosen so it is not always restarting on the same "hour" 
boundary
+    run_duration: 41460
+  elasticsearch:
+    json_format: 'True'
+    log_id_template: "{dag_id}_{task_id}_{execution_date}_{try_number}"
+  elasticsearch_configs:
+    max_retries: 3
+    timeout: 30
+    retry_timeout: 'True'
+
+  kubernetes:
+    namespace: '{{ .Release.Namespace }}'
+    airflow_configmap: '{{ include "airflow_config" . }}'
+    airflow_local_settings_configmap: '{{ include "airflow_config" . }}'
+    worker_container_repository: '{{ .Values.images.airflow.repository | 
default .Values.defaultAirflowRepository }}'
+    worker_container_tag: '{{ .Values.images.airflow.tag | default 
.Values.defaultAirflowTag }}'
+    worker_container_image_pull_policy: '{{ .Values.images.airflow.pullPolicy 
}}'
+    worker_service_account_name: '{{ .Release.Name }}-worker-serviceaccount'
+    image_pull_secrets: '{{ template "registry_secret" . }}'
+    dags_in_image: '{{- if or .Values.dags.gitSync.enabled 
.Values.dags.persistence.enabled }}False{{ else }}True{{ end }}'

Review comment:
       ```suggestion
       dags_in_image: '{{ ternary "False" "True" (or 
.Values.dags.gitSync.enabled .Values.dags.persistence.enabled) }}'
   ```
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to