kaxil commented on pull request #9008: URL: https://github.com/apache/airflow/pull/9008#issuecomment-659322116
> > Please add tests > > Sure, but what kind of tests? I assumed that since there are already tests, if they work with the new script it'll be fine. Tests that check that you get set `conn_id`, `conn_type` etc and that you can still get that Connection back in here: https://github.com/apache/airflow/blob/master/tests/providers/amazon/aws/secrets/test_secrets_manager.py ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
