aneesh-joseph edited a comment on pull request #9778: URL: https://github.com/apache/airflow/pull/9778#issuecomment-660422498
> @dimberman The base_url option adds a prefix to each address (including health check), so this change looks good. This option is implemented as WSGI middleware, so it affects all addresses. This option is not related to reverse proxy, but is often used together. We have a similar option - proxy_fix and it is closely related to the option and has a similar purpose, but a different way of working. > Please look here: > https://github.com/apache/airflow/blob/master/tests/www/test_app.py So localhost:airflowport/health wont work if base_url is set? If that's the case may be the webserver should be tweaked to make sure that the healthcheck url is excluded from this prefixing? I think it doesn't make sense to set the probes on the reverse proxy url. Probes are a way for kubernetes to check if that specific pod-container is healthy, the reverse proxied health url doesn't give that information ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
