mik-laj commented on a change in pull request #9883:
URL: https://github.com/apache/airflow/pull/9883#discussion_r457056793



##########
File path: airflow/providers/openfaas/hooks/openfaas.py
##########
@@ -52,7 +52,7 @@ def get_conn(self):
         conn = self.get_connection(self.conn_id)
         return conn
 
-    def deploy_function(self, overwrite_function_if_exist, body):
+    def deploy_function(self, overwrite_function_if_exist: bool, body: str) -> 
None:

Review comment:
       ```suggestion
       def deploy_function(self, overwrite_function_if_exist: bool, body: 
Dict[str, Any]) -> None:
   ```

##########
File path: airflow/providers/openfaas/hooks/openfaas.py
##########
@@ -70,7 +70,7 @@ def deploy_function(self, overwrite_function_if_exist, body):
             else:
                 self.log.info("Function deployed %s", self.function_name)
 
-    def invoke_async_function(self, body):
+    def invoke_async_function(self, body: str) -> None:

Review comment:
       ```suggestion
       def invoke_async_function(self, body: : Dict[str, Any]) -> None:
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to