zikun commented on a change in pull request #9911:
URL: https://github.com/apache/airflow/pull/9911#discussion_r458075627
##########
File path: airflow/providers/elasticsearch/log/es_task_handler.py
##########
@@ -55,12 +57,19 @@ class ElasticsearchTaskHandler(FileTaskHandler,
LoggingMixin):
MAX_LINE_PER_PAGE = 1000
LOG_NAME = 'Elasticsearch'
- def __init__(self, base_log_folder, filename_template, # pylint:
disable=too-many-arguments
- log_id_template, end_of_log_mark,
- write_stdout, json_format, json_fields,
- host='localhost:9200',
- frontend='localhost:5601',
- es_kwargs=conf.getsection("elasticsearch_configs")):
+ def __init__( # pylint: disable=too-many-arguments
+ self,
+ base_log_folder: str,
+ filename_template: str,
+ log_id_template: str,
+ end_of_log_mark: str,
+ write_stdout,
+ json_format,
+ json_fields,
Review comment:
oops. Missed them. Just added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
