potiuk commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r460192737
##########
File path: Dockerfile.ci
##########
@@ -309,6 +322,8 @@ RUN if [[ -n "${ADDITIONAL_PYTHON_DEPS}" ]]; then \
pip install ${ADDITIONAL_PYTHON_DEPS}; \
fi
+RUN pip install pyodbc
Review comment:
Docker does it on its own - whenever you add anything from local context
with COPY or ADD it calculates hashes of the added files and will invalidate
the cache when they're different from the ones used to build it previously.
That's why we are adding setup.py in Dockerfile separately at some point in
Dockerfile - to only invalidate the cache if setup.py changes (but I also do a
smart pre-caching where I install all deps from github first - so that
changing setup.py will not invalidate all installed pip reps.
This results with much faster rebuilds when we add or upgrade something in
setup.py (this way only the changed deps got added/upgraded) but when we remove
something, we need to increase the EPOCH, so that when it's merged to master,
it will reinstall it from the scratch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
